Changeset 0129700 in network-game

Timestamp:

Dec 19, 2013, 3:31:45 AM (11 years ago)

Author:

dportnoy <dmp1488@…>

Branches:

master

Children:

fef7c69

Parents:

70fc3e8

Message:

The Game class validates player movement on the server side

Files:

• common/Game.cpp (modified) (1 diff)
• common/Game.h (modified) (1 diff)
• server/server.cpp (modified) (1 diff)

common/Game.cpp

@@ -67 +67 @@
 }
 
+bool Game::startPlayerMovement(unsigned int id, int x, int y) {
+   // need to check if players actually contains the id
+   Player* p = players[id];
+
+   // we need to make sure the player can move here
+   if (0 <= x && x < this->worldMap->width*25 &&
+       0 <= y && y < this->worldMap->height*25 &&
+       this->worldMap->getElement(x/25, y/25) == WorldMap::TERRAIN_GRASS)
+   {
+      p->target.x = x;
+      p->target.y = y;
+
+      p->isChasing = false;
+      p->isAttacking = false;
+
+      return true;
+   }
+   else
+      return false;
+}
+
 void Game::setRedScore(int score) {
    this->redScore = score;

common/Game.h

@@ -41 +41 @@
    bool addPlayer(Player* p);
    bool removePlayer(unsigned int id);
+   bool startPlayerMovement(unsigned int id, int x, int y);
    void setBlueScore(int score);
    void setRedScore(int score);

server/server.cpp

@@ -818 +818 @@
               p->addr.sin_port == from.sin_port )
          {
-            // we need to make sure the player can move here
-            if (0 <= x && x < gameMap->width*25 && 0 <= y && y < gameMap->height*25 &&
-               gameMap->getElement(x/25, y/25) == WorldMap::TERRAIN_GRASS)
-            {
-               cout << "valid terrain" << endl;
-
-               p->target.x = x;
-               p->target.y = y;
-
-               p->isChasing = false;
-               p->isAttacking = false;
-
+            if (p->currentGame->startPlayerMovement(id, x, y)) {
                serverMsg.type = MSG_TYPE_PLAYER_MOVE;