Changeset 453087e in network-game

Timestamp:

Dec 17, 2013, 11:35:52 PM (11 years ago)

Author:

dportnoy <dmp1488@…>

Branches:

master

Children:

6012178

Parents:

31b347a

Message:

PLAYER_JOIN_GAME messages, rather than PLAYER ones, are now sent to indicate players joining specific matches. The server also sends a player just joining a match all players currently in the match, including the new player

Files:

• common/MessageContainer.h (modified) (1 diff)
• server/server.cpp (modified) (3 diffs)

common/MessageContainer.h

@@ -37 +37 @@
 #define MSG_TYPE_JOIN_GAME_FAILURE 22
 #define MSG_TYPE_JOIN_GAME_ACK     23
+#define MSG_TYPE_PLAYER_JOIN_GAME  24
 
 typedef struct

server/server.cpp

@@ -1103 +1103 @@
          p->currentGame = g; // should have been done in JOIN_GAME, so not necessary
 
-         map<unsigned int, Player*>& otherPlayers = g->getPlayers();
-
-         // tell the new player about all the existing players
-         cout << "Sending other players to new player" << endl;
-         serverMsg.type = MSG_TYPE_PLAYER;
-
-         map<unsigned int, Player*>::iterator it;
-         for (it = otherPlayers.begin(); it != otherPlayers.end(); it++)
-         {
-            it->second->serialize(serverMsg.buffer);
-
-            cout << "sending info about " << it->second->name  << endl;
-            cout << "sending id " << it->second->id  << endl;
-            if ( msgProcessor.sendMessage(&serverMsg, sock, &from, &outputLog) < 0 )
-               error("sendMessage");
-         }
-
          // tell the new player about all map objects
          // (currently just the flags)
@@ -1146 +1129 @@
             error("sendMessage");
 
-         serverMsg.type = MSG_TYPE_PLAYER;
+         serverMsg.type = MSG_TYPE_PLAYER_JOIN_GAME;
          p->serialize(serverMsg.buffer);
          cout << "Should be broadcasting the message" << endl;
 
+         map<unsigned int, Player*>& otherPlayers = g->getPlayers();
          for (it = otherPlayers.begin(); it != otherPlayers.end(); it++)
          {
@@ -1158 +1142 @@
 
          g->addPlayer(p);
+
+         map<unsigned int, Player*>& allPlayers = g->getPlayers();
+
+         // tell the new player about all the players in the game (including himself)
+         cout << "Sending other players to new player" << endl;
+         serverMsg.type = MSG_TYPE_PLAYER_JOIN_GAME;
+
+         map<unsigned int, Player*>::iterator it;
+         for (it = allPlayers.begin(); it != allPlayers.end(); it++)
+         {
+            it->second->serialize(serverMsg.buffer);
+
+            cout << "sending info about " << it->second->name  << endl;
+            cout << "sending id " << it->second->id  << endl;
+            if ( msgProcessor.sendMessage(&serverMsg, sock, &from, &outputLog) < 0 )
+               error("sendMessage");
+         }
+
          int numPlayers = g->getNumPlayers();