Changeset 5ea0a37 in opengl-game

Timestamp:

Jun 11, 2021, 10:05:25 PM (3 years ago)

Author:

Dmitry Portnoy <dportnoy@…>

Branches:

feature/imgui-sdl

Children:

90880fb

Parents:

6486ba8

Message:

Add a function to VulkanBuffer to return a pointer to the buffer memory, and replace the use of updateBufferSet with copyDataToMemory to update all the data for a single pipeline in one call

Files:

• sdl-game.cpp (modified) (1 diff)
• sdl-game.hpp (modified) (2 diffs)
• vulkan-buffer.hpp (modified) (6 diffs)
• vulkan-game.cpp (modified) (6 diffs)
• vulkan-game.hpp (modified) (2 diffs)

sdl-game.cpp

@@ -465 +465 @@
       objData.model = obj.model_transform * obj.model_base;
       obj.center = vec3(objData.model * vec4(0.0f, 0.0f, 0.0f, 1.0f));
-
-      updateBufferSet(storageBuffers_modelPipeline, i, objData);
-   }
+   }
+
+   VulkanUtils::copyDataToMemory(device, objects_modelPipeline.data(), storageBuffers_modelPipeline.memory[imageIndex],
+                                 0, objects_modelPipeline.memorySize(), false);
 
    VulkanUtils::copyDataToMemory(device, &object_VP_mats, uniformBuffers_modelPipeline.memory[imageIndex], 0,

sdl-game.hpp

@@ -300 +300 @@
                            bool copyData);
 
-      template<class SSBOType>
-      void updateBufferSet(BufferSet& set, size_t objIndex, SSBOType& ssbo);
-
       // TODO: Since addObject() returns a reference to the new object now,
       // stop using objects.back() to access the object that was just created
@@ -338 +335 @@
       void quitGame();
 };
-
-// TODO: See if it makes sense to pass in the current swapchain index instead of updating all of them
-template<class SSBOType>
-void VulkanGame::updateBufferSet(BufferSet& set, size_t objIndex, SSBOType& ssbo) {
-   for (size_t i = 0; i < set.memory.size(); i++) {
-      VulkanUtils::copyDataToMemory(device, &ssbo, set.memory[i], objIndex * sizeof(SSBOType), sizeof(ssbo), false);
-   }
-}
 
 // TODO: Right now, it's basically necessary to pass the identity matrix in for ssbo.model and to change

vulkan-buffer.hpp

@@ -31 +31 @@
       VulkanBuffer<T>& operator=(VulkanBuffer<T>&& other) noexcept;
 
-      void resize();
+      size_t memorySize();
+
+      T* data();  // Not sure I need to expose this
 
       T& get(uint32_t index);
       void add(T obj);
 
-      size_t memorySize();
+      void resize();
 
    private:
@@ -114 +116 @@
       range = other.range;
 
+      mappedData = other.mappedData;
+
       if (rawData != nullptr) {
          free(rawData);
@@ -124 +128 @@
       other.range = 0;
 
+      other.mappedData.clear();
       other.rawData = nullptr;
    }
@@ -131 +136 @@
 
 template<class T>
-void VulkanBuffer<T>::resize() {
-   resized = false;
+size_t VulkanBuffer<T>::memorySize() {
+   return memRequirement(capacity);
+}
+
+template<class T>
+T* VulkanBuffer<T>::data() {
+   return rawData;
 }
 
@@ -145 +155 @@
 template<class T>
 void VulkanBuffer<T>::add(T obj) {
+   // TODO: Maybe copy this to the resize() function and call that function here
    if (numObjects == capacity) {
       // Once I add Vulkan buffer objects in here, make sure this doesn't overlap with resizeBufferSet
@@ -171 +182 @@
 
 template<class T>
-size_t VulkanBuffer<T>::memorySize() {
-   return memRequirement(capacity);
+void VulkanBuffer<T>::resize() {
+   resized = false;
 }
 

vulkan-game.cpp

@@ -1022 +1022 @@
 
    // TODO: Probably move the resizing to the VulkanBuffer class
-
-   // TODO: Replace updateBufferSet to one call to copyDataToMemory, using VulkanBuffer to provide the data source
    // TODO: Figure out a way to make updateDescriptorInfo easier to use, maybe store the binding index in the buffer set
 
@@ -1046 +1044 @@
       objData.model = obj.model_transform * obj.model_base;
       obj.center = vec3(objData.model * vec4(0.0f, 0.0f, 0.0f, 1.0f));
-
-      updateBufferSet(storageBuffers_modelPipeline, i, objData);
-   }
+   }
+
+   VulkanUtils::copyDataToMemory(device, objects_modelPipeline.data(), storageBuffers_modelPipeline.memory[imageIndex],
+                                 0, objects_modelPipeline.memorySize(), false);
 
    if (objects_shipPipeline.resized) {
@@ -1066 +1065 @@
       objData.model = obj.model_transform * obj.model_base;
       obj.center = vec3(objData.model * vec4(0.0f, 0.0f, 0.0f, 1.0f));
-
-      updateBufferSet(storageBuffers_shipPipeline, i, objData);
-   }
+   }
+
+   VulkanUtils::copyDataToMemory(device, objects_shipPipeline.data(), storageBuffers_shipPipeline.memory[imageIndex],
+                                 0, objects_shipPipeline.memorySize(), false);
 
    if (objects_asteroidPipeline.resized) {
@@ -1108 +1108 @@
          objData.model = obj.model_transform * obj.model_base;
          obj.center = vec3(objData.model * vec4(0.0f, 0.0f, 0.0f, 1.0f));
-
-         updateBufferSet(storageBuffers_asteroidPipeline, i, objData);
       }
    }
+
+   VulkanUtils::copyDataToMemory(device, objects_asteroidPipeline.data(), storageBuffers_asteroidPipeline.memory[imageIndex],
+                                 0, objects_asteroidPipeline.memorySize(), false);
 
    if (objects_laserPipeline.resized) {
@@ -1135 +1136 @@
       objData.model = obj.model_transform * obj.model_base;
       obj.center = vec3(objData.model * vec4(0.0f, 0.0f, 0.0f, 1.0f));
-
-      updateBufferSet(storageBuffers_laserPipeline, i, objData);
-   }
+   }
+
+   VulkanUtils::copyDataToMemory(device, objects_laserPipeline.data(), storageBuffers_laserPipeline.memory[imageIndex],
+                                 0, objects_laserPipeline.memorySize(), false);
 
    if (objects_explosionPipeline.resized) {
@@ -1160 +1162 @@
       objData.model = obj.model_transform * obj.model_base;
       obj.center = vec3(objData.model * vec4(0.0f, 0.0f, 0.0f, 1.0f));
-
-      updateBufferSet(storageBuffers_explosionPipeline, i, objData);
-   }
+   }
+
+   VulkanUtils::copyDataToMemory(device, objects_explosionPipeline.data(), storageBuffers_explosionPipeline.memory[imageIndex],
+                                 0, objects_explosionPipeline.memorySize(), false);
 
    explosion_UBO.cur_time = curTime;

vulkan-game.hpp

@@ -432 +432 @@
                            bool copyData);
 
-      template<class SSBOType>
-      void updateBufferSet(BufferSet& set, size_t objIndex, SSBOType& ssbo);
-
       // TODO: Since addObject() returns a reference to the new object now,
       // stop using objects.back() to access the object that was just created
@@ -490 +487 @@
 
 // End of specialized no-op functions
-
-// TODO: See if it makes sense to pass in the current swapchain index instead of updating all of them
-template<class SSBOType>
-void VulkanGame::updateBufferSet(BufferSet& set, size_t objIndex, SSBOType& ssbo) {
-   for (size_t i = 0; i < set.memory.size(); i++) {
-      VulkanUtils::copyDataToMemory(device, &ssbo, set.memory[i], objIndex * sizeof(SSBOType), sizeof(ssbo), false);
-   }
-}
 
 // TODO: Right now, it's basically necessary to pass the identity matrix in for ssbo.model and to change