Changeset 7511a2b in network-game

Timestamp:

May 25, 2013, 6:49:14 PM (11 years ago)

Author:

dportnoy <dmp1488@…>

Branches:

master

Children:

b8cb03f

Parents:

e487381

Message:

Resolved a bug where objects with duplicate ids were getting created

Files:

• client/Client/main.cpp (modified) (5 diffs)
• common/WorldMap.cpp (modified) (3 diffs)

client/Client/main.cpp

@@ -453 +453 @@
             case MSG_TYPE_PLAYER:   // kind of hacky to put this here
             {
-               cout << "Got MSG_TYPE_PLAYER message in Start" << endl;
+               cout << "Got MSG_TYPE_PLAYER message in STATE_START" << endl;
 
                Player p("", "");
@@ -467 +467 @@
             case MSG_TYPE_OBJECT:
             {
-               cout << "Received object message. Baller Biller!" << endl;
+               cout << "Received OBJECT message in STATE_START." << endl;
 
                WorldMap::Object o(0, WorldMap::OBJECT_NONE, 0, 0);
                o.deserialize(msg.buffer);
+               cout << "object id: " << o.id << endl;
                gameMap->updateObject(o.id, o.type, o.pos.x, o.pos.y);
 
@@ -511 +512 @@
             case MSG_TYPE_PLAYER:
             {
-               cout << "Got MSG_TYPE_PLAYER message in Login" << endl;
+               cout << "Got MSG_TYPE_PLAYER message in STATE_LOGIN" << endl;
 
                Player p("", "");
@@ -544 +545 @@
             case MSG_TYPE_OBJECT:
             {
-               cout << "Received object message. Baller Biller!" << endl;
+               cout << "Received object message in STATE_LOGIN." << endl;
 
                WorldMap::Object o(0, WorldMap::OBJECT_NONE, 0, 0);
@@ -554 +555 @@
             case MSG_TYPE_REMOVE_OBJECT:
             {
+               cout << "Received REMOVE_OBJECT message!" << endl;
+
                int id;
                memcpy(&id, msg.buffer, 4);
+
+               cout << "Removing object with id " << id << endl;
+
                if (!gameMap->removeObject(id))
                   cout << "Did not remove the object" << endl;
+
+               break;
             }
             default:

common/WorldMap.cpp

@@ -68 +68 @@
    return vctObjects;
 }
+
 vector<WorldMap::Object> WorldMap::getObjects(int x, int y) {
    vector<WorldMap::Object> vctObjectsInRegion;
 
    vector<WorldMap::Object>::iterator it;
-   for(it = vctObjects->begin(); it != vctObjects->end(); it++) {
+   for (it = vctObjects->begin(); it != vctObjects->end(); it++) {
       if (it->pos.x/25 == x && it->pos.y/25 == y)
          vctObjectsInRegion.push_back(*it);
@@ -82 +83 @@
 // used by the server to create new objects
 void WorldMap::addObject(WorldMap::ObjectType t, int x, int y) {
-   WorldMap::Object o(vctObjects->size(), t, x, y);
+   int id;
+   vector<WorldMap::Object>::iterator it;
+
+   for (id = 0; id < vctObjects->size(); id++) {
+      for (it = vctObjects->begin(); it != vctObjects->end(); it++) {
+         if (id == it->id)
+            break;
+      }
+
+      if (it == vctObjects->end())  // if no objects with this id exists
+         break;
+   }
+
+   WorldMap::Object o(id, t, x, y);
    vctObjects->push_back(o);
 }
@@ -91 +105 @@
    bool foundObject = false;
 
+   cout << "Searching for obbject to update" << endl;
+   switch (t) {
+   case WorldMap::OBJECT_BLUE_FLAG:
+      cout << "BLUE_FLAG" << endl;
+      break;
+   case WorldMap::OBJECT_RED_FLAG:
+      cout << "RED_FLAG" << endl;
+      break;
+   }
+
    for (it = vctObjects->begin(); it != vctObjects->end(); it++) {
       if (it->id == id) {
          foundObject = true;
+         cout << "Found object with id " << id << endl;
+         switch (it->type) {
+         case WorldMap::OBJECT_BLUE_FLAG:
+            cout << "BLUE_FLAG" << endl;
+            break;
+         case WorldMap::OBJECT_RED_FLAG:
+            cout << "RED_FLAG" << endl;
+            break;
+         }
          it->pos.x = x;
          it->pos.y = y;