Changeset f9cb9fb in network-game for common

Timestamp:

Aug 3, 2013, 12:52:15 AM (11 years ago)

Author:

dportnoy <dmp1488@…>

Branches:

master

Children:

753fa8a

Parents:

8271c78

Message:

The ackedMessages list in MessageProcessor now stores ack records based on sender address and message id so that messages with the same id, but from different senders are distinguishable

Location:

common

Files:

• MessageProcessor.cpp (modified) (4 diffs)
• MessageProcessor.h (modified) (2 diffs)

common/MessageProcessor.cpp

@@ -50 +50 @@
    }else {
       bool isDuplicate = false;
+      map<unsigned int, unsigned long long>& ackedPlayerMessages = ackedMessages[source->sin_addr.s_addr];
 
-      if (ackedMessages.find(msg->id) != ackedMessages.end()) {
+      if (ackedPlayerMessages.find(msg->id) != ackedPlayerMessages.end()) {
          isDuplicate = true;
          cout << "Got duplicate of type " << msg->type << endl;
+         if (outputLog)
+            (*outputLog) << "Received duplicate (id " << msg->id << ") of type " << MessageContainer::getMsgTypeString(msg->type) << endl;
       }else {
          cout << "Got message of type " << msg->type << endl;
@@ -60 +63 @@
       }
 
-      ackedMessages[msg->id] = MessageContainer(*msg, *source);
-      ackedMessages[msg->id].setAcked(true);
-      ackedMessages[msg->id].setTimeAcked(getCurrentMillis());
+      ackedPlayerMessages[msg->id] = getCurrentMillis();
 
       NETWORK_MSG ack;
@@ -116 +117 @@
    }
 
-   /*
-   map<unsigned int, unsigned long long>::iterator it3 = ackedMessages.begin();
+   map<unsigned long, map<unsigned int, unsigned long long> >::iterator it3 = ackedMessages.begin();
+   map<unsigned int, unsigned long long>::iterator it4;
 
+   // somehow want to delete the inner map once that player logs out
    while (it3 != ackedMessages.end()) {
-      if ((getCurrentMillis() - it3->second) > 500)
-         ackedMessages.erase(it3++);
-      else
-         it3++;
+      it4 = it3->second.begin();
+      while (it4 != it3->second.end()) {
+         if ((getCurrentMillis() - it4->second) > 500)
+            it3->second.erase(it4++);
+         else
+            it4++;
+      }
+      it3++;
    }
-   */
 }
 
@@ -132 +137 @@
 }
 
-map<unsigned int, MessageContainer>& MessageProcessor::getAckedMessages() {
+map<unsigned long, map<unsigned int, unsigned long long> >& MessageProcessor::getAckedMessages() {
    return this->ackedMessages;
 }

common/MessageProcessor.h

@@ -15 +15 @@
    map<unsigned int, map<unsigned long, MessageContainer> > sentMessages;
 
-   // map from message ids to the time each mesage was acked
-   map<unsigned int, MessageContainer> ackedMessages;
+   // map from player address to map from message id to time accked
+   map<unsigned long, map<unsigned int, unsigned long long> > ackedMessages;
 
    unsigned long pid;
@@ -30 +30 @@
 
    map<unsigned int, map<unsigned long, MessageContainer> >& getSentMessages();
-   map<unsigned int, MessageContainer>& getAckedMessages();
+   map<unsigned long, map<unsigned int, unsigned long long> >& getAckedMessages();
 };