Changeset 7865c5b in opengl-game for sdl-game.cpp

Timestamp:

Mar 17, 2021, 12:50:49 AM (4 years ago)

Author:

Dmitry Portnoy <dportnoy@…>

Branches:

feature/imgui-sdl

Children:

aa7e5f0

Parents:

85b5fec

Message:

Rename surface to vulkanSurface and add an initializer list to the VulkanGame constructor

File:

• sdl-game.cpp (modified) (13 diffs)

sdl-game.cpp

@@ -40 +40 @@
 }
 
-VulkanGame::VulkanGame() {
-   // TODO: Double-check whether initialization should happen in the header, where the variables are declared, or here
-   // Also, decide whether to use this-> for all instance variables, or only when necessary
-
-   debugMessenger = VK_NULL_HANDLE;
-
-   gui = nullptr;
-   window = nullptr;
-
-   swapChainPresentMode = VK_PRESENT_MODE_MAX_ENUM_KHR;
-   swapChainMinImageCount = 0;
-   currentFrame = 0;
-   imageIndex = 0;
-   shouldRecreateSwapChain = false;
-
-   score = 0;
-   fps = 0.0f;
+VulkanGame::VulkanGame()
+                     : swapChainImageCount(0)
+                     , swapChainMinImageCount(0)
+                     , swapChainSurfaceFormat({})
+                     , swapChainPresentMode(VK_PRESENT_MODE_MAX_ENUM_KHR)
+                     , swapChainExtent{ 0, 0 }
+                     , swapChain(VK_NULL_HANDLE)
+                     , vulkanSurface(VK_NULL_HANDLE)
+                     , sdlVersion({ 0, 0, 0 })
+                     , instance(VK_NULL_HANDLE)
+                     , physicalDevice(VK_NULL_HANDLE)
+                     , device(VK_NULL_HANDLE)
+                     , debugMessenger(VK_NULL_HANDLE)
+                     , resourceCommandPool(VK_NULL_HANDLE)
+                     , renderPass(VK_NULL_HANDLE)
+                     , graphicsQueue(VK_NULL_HANDLE)
+                     , presentQueue(VK_NULL_HANDLE)
+                     , depthImage({})
+                     , shouldRecreateSwapChain(false)
+                     , frameCount(0)
+                     , currentFrame()
+                     , imageIndex(0)
+                     , fpsStartTime(0.0f)
+                     , curTime(0.0f)
+                     , done(false)
+                     , currentRenderScreenFn(nullptr)
+                     , descriptorPool(VK_NULL_HANDLE)
+                     , gui(nullptr)
+                     , window(nullptr)
+                     , score(0)
+                     , fps(0.0f) {
 }
 
@@ -104 +118 @@
 
    // TODO: Do this in one place and save it instead of redoing it every time I need a queue family index
-   QueueFamilyIndices indices = VulkanUtils::findQueueFamilies(physicalDevice, surface);
+   QueueFamilyIndices indices = VulkanUtils::findQueueFamilies(physicalDevice, vulkanSurface);
 
    // Setup Dear ImGui context
@@ -376 +390 @@
 
    vkDestroyDevice(device, nullptr);
-   vkDestroySurfaceKHR(instance, surface, nullptr);
+   vkDestroySurfaceKHR(instance, vulkanSurface, nullptr);
 
    if (ENABLE_VALIDATION_LAYERS) {
@@ -461 +475 @@
 
 void VulkanGame::createVulkanSurface() {
-   if (gui->createVulkanSurface(instance, &surface) == RTWO_ERROR) {
+   if (gui->createVulkanSurface(instance, &vulkanSurface) == RTWO_ERROR) {
       throw runtime_error("failed to create window surface!");
    }
@@ -507 +521 @@
    }
 
-   QueueFamilyIndices indices = VulkanUtils::findQueueFamilies(physicalDevice, surface);
+   QueueFamilyIndices indices = VulkanUtils::findQueueFamilies(physicalDevice, vulkanSurface);
    bool extensionsSupported = VulkanUtils::checkDeviceExtensionSupport(physicalDevice, deviceExtensions);
    bool swapChainAdequate = false;
 
    if (extensionsSupported) {
-      vector<VkSurfaceFormatKHR> formats = VulkanUtils::querySwapChainFormats(physicalDevice, surface);
-      vector<VkPresentModeKHR> presentModes = VulkanUtils::querySwapChainPresentModes(physicalDevice, surface);
+      vector<VkSurfaceFormatKHR> formats = VulkanUtils::querySwapChainFormats(physicalDevice, vulkanSurface);
+      vector<VkPresentModeKHR> presentModes = VulkanUtils::querySwapChainPresentModes(physicalDevice, vulkanSurface);
 
       swapChainAdequate = !formats.empty() && !presentModes.empty();
@@ -526 +540 @@
 void VulkanGame::createLogicalDevice(const vector<const char*>& validationLayers,
    const vector<const char*>& deviceExtensions) {
-   QueueFamilyIndices indices = VulkanUtils::findQueueFamilies(physicalDevice, surface);
+   QueueFamilyIndices indices = VulkanUtils::findQueueFamilies(physicalDevice, vulkanSurface);
 
    if (!indices.isComplete()) {
@@ -582 +596 @@
 
 void VulkanGame::chooseSwapChainProperties() {
-   vector<VkSurfaceFormatKHR> availableFormats = VulkanUtils::querySwapChainFormats(physicalDevice, surface);
-   vector<VkPresentModeKHR> availablePresentModes = VulkanUtils::querySwapChainPresentModes(physicalDevice, surface);
+   vector<VkSurfaceFormatKHR> availableFormats = VulkanUtils::querySwapChainFormats(physicalDevice, vulkanSurface);
+   vector<VkPresentModeKHR> availablePresentModes = VulkanUtils::querySwapChainPresentModes(physicalDevice, vulkanSurface);
 
    // Per Spec Format and View Format are expected to be the same unless VK_IMAGE_CREATE_MUTABLE_BIT was set at image creation
@@ -605 +619 @@
    cout << "[vulkan] Selected PresentMode = " << swapChainPresentMode << endl;
 
-   VkSurfaceCapabilitiesKHR capabilities = VulkanUtils::querySwapChainCapabilities(physicalDevice, surface);
+   VkSurfaceCapabilitiesKHR capabilities = VulkanUtils::querySwapChainCapabilities(physicalDevice, vulkanSurface);
 
    // If min image count was not specified, request different count of images dependent on selected present mode
@@ -632 +646 @@
 
 void VulkanGame::createSwapChain() {
-   VkSurfaceCapabilitiesKHR capabilities = VulkanUtils::querySwapChainCapabilities(physicalDevice, surface);
+   VkSurfaceCapabilitiesKHR capabilities = VulkanUtils::querySwapChainCapabilities(physicalDevice, vulkanSurface);
 
    swapChainExtent = VulkanUtils::chooseSwapExtent(capabilities, gui->getWindowWidth(), gui->getWindowHeight());
@@ -638 +652 @@
    VkSwapchainCreateInfoKHR createInfo = {};
    createInfo.sType = VK_STRUCTURE_TYPE_SWAPCHAIN_CREATE_INFO_KHR;
-   createInfo.surface = surface;
+   createInfo.surface = vulkanSurface;
    createInfo.minImageCount = swapChainMinImageCount;
    createInfo.imageFormat = swapChainSurfaceFormat.format;
@@ -647 +661 @@
 
    // TODO: Maybe save this result so I don't have to recalculate it every time
-   QueueFamilyIndices indices = VulkanUtils::findQueueFamilies(physicalDevice, surface);
+   QueueFamilyIndices indices = VulkanUtils::findQueueFamilies(physicalDevice, vulkanSurface);
    uint32_t queueFamilyIndices[] = { indices.graphicsFamily.value(), indices.presentFamily.value() };
 
@@ -762 +776 @@
 
 void VulkanGame::createResourceCommandPool() {
-   QueueFamilyIndices indices = VulkanUtils::findQueueFamilies(physicalDevice, surface);
+   QueueFamilyIndices indices = VulkanUtils::findQueueFamilies(physicalDevice, vulkanSurface);
 
    VkCommandPoolCreateInfo poolInfo = {};
@@ -777 +791 @@
    commandPools.resize(swapChainImageCount);
 
-   QueueFamilyIndices indices = VulkanUtils::findQueueFamilies(physicalDevice, surface);
+   QueueFamilyIndices indices = VulkanUtils::findQueueFamilies(physicalDevice, vulkanSurface);
 
    for (size_t i = 0; i < swapChainImageCount; i++) {