Changeset 81869ef in opengl-game

Timestamp:

Feb 14, 2021, 4:08:47 PM (3 years ago)

Author:

Dmitry Portnoy <dportnoy@…>

Branches:

feature/imgui-sdl

Children:

8d96e95

Parents:

484334e

Message:

Avoid rendering frames while the window is minimized

Files:

• sdl-game.cpp (modified) (1 diff)
• vulkan-game.cpp (modified) (1 diff)

sdl-game.cpp

@@ -209 +209 @@
 
       ImGui::Render();
-      ImDrawData* draw_data = ImGui::GetDrawData();
-      const bool is_minimized = (draw_data->DisplaySize.x <= 0.0f || draw_data->DisplaySize.y <= 0.0f);
-      if (!is_minimized) {
-         renderFrame(draw_data);
+
+      gui->refreshWindowSize();
+
+      const bool isMinimized = gui->getWindowWidth() <= 0 || gui->getWindowHeight() <= 0;
+
+      if (!isMinimized) {
+         renderFrame(ImGui::GetDrawData());
          presentFrame();
       }

vulkan-game.cpp

@@ -986 +986 @@
       ImGui::Render();
 
-      renderFrame(ImGui::GetDrawData());
-      presentFrame();
+      // There is already code in renderFrame to render screen-specific things
+      // The imgui code above should be moved to the renderUI function of the particular screen it's needed in
+      // and currentScreen->renderUI should be called in renderFrame.
+      // Since I am no longer drawing the UI to an sdl texture and then rendering that, I don't have to worry
+      // about calling populateVulkanImageFromSDLTexture at all.
+      // If I do ever want to do that again, I can still actually do it inside renderFrame
+
+      gui->refreshWindowSize();
+
+      const bool isMinimized = gui->getWindowWidth() <= 0 || gui->getWindowHeight() <= 0;
+
+      if (!isMinimized) {
+         renderFrame(ImGui::GetDrawData());
+         presentFrame();
+      }
    }
 }