Changeset 8d96e95 in opengl-game

Timestamp:

Feb 14, 2021, 6:37:24 PM (3 years ago)

Author:

Dmitry Portnoy <dportnoy@…>

Branches:

feature/imgui-sdl

Children:

6053b24

Parents:

81869ef

Message:

Avoid recreating the swap chain when the window is minimized

Files:

• game-gui-sdl.cpp (modified) (1 diff)
• sdl-game.cpp (modified) (2 diffs)
• vulkan-game.cpp (modified) (3 diffs)

game-gui-sdl.cpp

@@ -157 +157 @@
    // TODO: Make sure this works on a mac (the analogous glfw function had issues on Mac retina displays)
    SDL_GetWindowSize(window, &windowWidth, &windowHeight);
+
+   if (SDL_GetWindowFlags(window) & SDL_WINDOW_MINIMIZED) {
+      windowWidth = 0;
+      windowHeight = 0;
+   }
 }
 

sdl-game.cpp

@@ -170 +170 @@
       if (shouldRecreateSwapChain) {
          gui->refreshWindowSize();
-
-         int width = gui->getWindowWidth();
-         int height = gui->getWindowHeight();
-         if (width > 0 && height > 0) {
+         const bool isMinimized = gui->getWindowWidth() == 0 || gui->getWindowHeight() == 0;
+
+         if (!isMinimized) {
             // TODO: This should be used if the min image count changes, presumably because a new surface was created
             // with a different image count or something like that. Maybe I want to add code to query for a new min image count
@@ -211 +210 @@
 
       gui->refreshWindowSize();
-
-      const bool isMinimized = gui->getWindowWidth() <= 0 || gui->getWindowHeight() <= 0;
+      const bool isMinimized = gui->getWindowWidth() == 0 || gui->getWindowHeight() == 0;
 
       if (!isMinimized) {

vulkan-game.cpp

@@ -938 +938 @@
       if (shouldRecreateSwapChain) {
          gui->refreshWindowSize();
-
-         int width = gui->getWindowWidth();
-         int height = gui->getWindowHeight();
-         if (width > 0 && height > 0) {
+         const bool isMinimized = gui->getWindowWidth() == 0 || gui->getWindowHeight() == 0;
+
+         if (!isMinimized) {
             // TODO: This should be used if the min image count changes, presumably because a new surface was created
             // with a different image count or something like that. Maybe I want to add code to query for a new min image count
@@ -965 +964 @@
 
       ImGui_ImplVulkan_NewFrame();
-      ImGui_ImplSDL2_NewFrame(this->window);
+      ImGui_ImplSDL2_NewFrame(window);
       ImGui::NewFrame();
 
@@ -994 +993 @@
 
       gui->refreshWindowSize();
-
-      const bool isMinimized = gui->getWindowWidth() <= 0 || gui->getWindowHeight() <= 0;
+      const bool isMinimized = gui->getWindowWidth() == 0 || gui->getWindowHeight() == 0;
 
       if (!isMinimized) {