Changeset e6bc0f4 in opengl-game for new-game.cpp

Timestamp:

May 10, 2019, 6:18:31 PM (5 years ago)

Author:

Dmitry Portnoy <dmitry.portnoy@…>

Branches:

feature/imgui-sdl, master, points-test

Children:

155a7cf

Parents:

c55614a

Message:

Add a callback for the window resize event

File:

• new-game.cpp (modified) (11 diffs)

new-game.cpp

@@ -167 +167 @@
 void mouse_button_callback(GLFWwindow* window, int button, int action, int mods);
 void key_callback(GLFWwindow* window, int key, int scancode, int action, int mods);
+void window_size_callback(GLFWwindow* window, int width, int height);
 
 void APIENTRY debugGlCallback(
@@ -261 +262 @@
 bool key_down[NUM_KEYS];
 
-int width = 640;
-int height = 480;
+int windowWidth = 640;
+int windowHeight = 480;
 
 vec3 cam_pos;
@@ -329 +330 @@
       const GLFWvidmode* vmode = glfwGetVideoMode(mon);
 
-      width = vmode->width;
-      height = vmode->height;
+      windowWidth = vmode->width;
+      windowHeight = vmode->height;
       cout << "Fullscreen resolution " << vmode->width << "x" << vmode->height << endl;
    }
-   window = glfwCreateWindow(width, height, "New OpenGL Game", mon, NULL);
+   window = glfwCreateWindow(windowWidth, windowHeight, "New OpenGL Game", mon, NULL);
 
    if (!window) {
@@ -342 +343 @@
 
    glfwMakeContextCurrent(window);
+   glViewport(0, 0, windowWidth, windowHeight);
+
    glewExperimental = GL_TRUE;
    glewInit();
@@ -351 +354 @@
       cout << "Bound debug callback" << endl;
    } else {
-     cout << "OpenGL debugg message callback is not supported" << endl;
+      cout << "OpenGL debug message callback is not supported" << endl;
    }
 
@@ -394 +397 @@
    glfwSetMouseButtonCallback(window, mouse_button_callback);
    glfwSetKeyCallback(window, key_callback);
+
+   glfwSetWindowSizeCallback(window, window_size_callback);
 
    const GLubyte* renderer = glGetString(GL_RENDERER);
@@ -590 +595 @@
    // (Maybe I should just use glm::perspective, after making sure it matches what I have now)
    float fov = 67.0f * ONE_DEG_IN_RAD;
-   float aspect = (float)width / (float)height;
+   float aspect = (float)windowWidth / (float)windowHeight;
 
    float range = tan(fov * 0.5f) * NEAR_CLIP;
@@ -961 +966 @@
       glClear(GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT);
 
+      // Anton's book suggests placing this here, after glClear(). Check it's impact on framerate
+      //glViewport(0, 0, windowWidth, windowHeight);
+
       switch (curState) {
          case STATE_MAIN_MENU:
@@ -1002 +1010 @@
       selectedObject = NULL;
 
-      float x = (2.0f*mouse_x) / width - 1.0f;
-      float y = 1.0f - (2.0f*mouse_y) / height;
+      float x = (2.0f*mouse_x) / windowWidth - 1.0f;
+      float y = 1.0f - (2.0f*mouse_y) / windowHeight;
 
       cout << "x: " << x << ", y: " << y << endl;
@@ -1051 +1059 @@
    // should be true for GLFW_PRESS and GLFW_REPEAT
    key_down[key] = (action != GLFW_RELEASE);
+}
+
+void window_size_callback(GLFWwindow* window, int width, int height) {
+   cout << "Window resized to (" << width << ", " << height << ")" << endl;
+
+   windowWidth = width;
+   windowHeight = height;
+
+   // TODO: Ideally, remove the window title bar when the window is maximized
+   // Check https://github.com/glfw/glfw/issues/778
+
+   // This requires glfw3.3. I think I have to upgrade
+   // Doesn't seem to be needed in OSX and also causes a segfault there
+   //glfwSetWindowAttrib(window, GLFW_DECORATED, GLFW_FALSE);
 }
 
@@ -2444 +2466 @@
       int padding = 4;
       ImGui::SetNextWindowPos(ImVec2(-padding, -padding), ImGuiCond_Once);
-      ImGui::SetNextWindowSize(ImVec2(width + 2 * padding, height + 2 * padding), ImGuiCond_Once);
+      ImGui::SetNextWindowSize(ImVec2(windowWidth + 2 * padding, windowHeight + 2 * padding), ImGuiCond_Always);
       ImGui::Begin("WndMain", NULL,
          ImGuiWindowFlags_NoTitleBar |