Changeset fa9fa1c in opengl-game

Timestamp:

Sep 27, 2019, 8:53:27 PM (5 years ago)

Author:

Dmitry Portnoy <dmitry.portnoy@…>

Branches:

feature/imgui-sdl, master, points-test

Children:

7563b8a, a0da009

Parents:

0e09340

Message:

In vulkangame, create the command pool

Files:

• vulkan-game.cpp (modified) (4 diffs)
• vulkan-game.hpp (modified) (3 diffs)
• vulkan-ref.cpp (modified) (5 diffs)

vulkan-game.cpp

@@ -104 +104 @@
    createImageViews();
    createRenderPass();
+   createCommandPool();
 }
 
@@ -167 +168 @@
    cleanupSwapChain();
 
+   vkDestroyCommandPool(device, commandPool, nullptr);
    vkDestroyDevice(device, nullptr);
    vkDestroySurfaceKHR(instance, surface, nullptr);
@@ -293 +295 @@
 }
 
-bool VulkanGame::isDeviceSuitable(VkPhysicalDevice device, const vector<const char*>& deviceExtensions) {
+bool VulkanGame::isDeviceSuitable(VkPhysicalDevice physicalDevice,
+      const vector<const char*>& deviceExtensions) {
    VkPhysicalDeviceProperties deviceProperties;
-   vkGetPhysicalDeviceProperties(device, &deviceProperties);
+   vkGetPhysicalDeviceProperties(physicalDevice, &deviceProperties);
 
    cout << "Device: " << deviceProperties.deviceName << endl;
 
-   QueueFamilyIndices indices = VulkanUtils::findQueueFamilies(device, surface);
-   bool extensionsSupported = VulkanUtils::checkDeviceExtensionSupport(device, deviceExtensions);
+   QueueFamilyIndices indices = VulkanUtils::findQueueFamilies(physicalDevice, surface);
+   bool extensionsSupported = VulkanUtils::checkDeviceExtensionSupport(physicalDevice, deviceExtensions);
    bool swapChainAdequate = false;
 
    if (extensionsSupported) {
-      SwapChainSupportDetails swapChainSupport = VulkanUtils::querySwapChainSupport(device, surface);
+      SwapChainSupportDetails swapChainSupport = VulkanUtils::querySwapChainSupport(physicalDevice, surface);
       swapChainAdequate = !swapChainSupport.formats.empty() && !swapChainSupport.presentModes.empty();
    }
 
    VkPhysicalDeviceFeatures supportedFeatures;
-   vkGetPhysicalDeviceFeatures(device, &supportedFeatures);
+   vkGetPhysicalDeviceFeatures(physicalDevice, &supportedFeatures);
 
    return indices.isComplete() && extensionsSupported && swapChainAdequate && supportedFeatures.samplerAnisotropy;
@@ -492 +495 @@
 }
 
+void VulkanGame::createCommandPool() {
+   QueueFamilyIndices queueFamilyIndices = VulkanUtils::findQueueFamilies(physicalDevice, surface);;
+
+   VkCommandPoolCreateInfo poolInfo = {};
+   poolInfo.sType = VK_STRUCTURE_TYPE_COMMAND_POOL_CREATE_INFO;
+   poolInfo.queueFamilyIndex = queueFamilyIndices.graphicsFamily.value();
+   poolInfo.flags = 0;
+
+   if (vkCreateCommandPool(device, &poolInfo, nullptr, &commandPool) != VK_SUCCESS) {
+      throw runtime_error("failed to create graphics command pool!");
+   }
+}
+
 void VulkanGame::cleanupSwapChain() {
    vkDestroyRenderPass(device, renderPass, nullptr);

vulkan-game.hpp

@@ -38 +38 @@
       VkExtent2D swapChainExtent;
       vector<VkImageView> swapChainImageViews;
+
       VkRenderPass renderPass;
+      VkCommandPool commandPool;
 
       bool framebufferResized = false;
@@ -54 +56 @@
       void createVulkanSurface();
       void pickPhysicalDevice(const vector<const char*>& deviceExtensions);
-      bool isDeviceSuitable(VkPhysicalDevice device, const vector<const char*>& deviceExtensions);
+      bool isDeviceSuitable(VkPhysicalDevice physicalDevice, const vector<const char*>& deviceExtensions);
       void createLogicalDevice(
          const vector<const char*> validationLayers,
@@ -62 +64 @@
       void createRenderPass();
       VkFormat findDepthFormat();
+      void createCommandPool();
 
       void cleanupSwapChain();

vulkan-ref.cpp

@@ -179 +179 @@
 /*** START OF REFACTORED CODE ***/
       VkRenderPass renderPass;
+
+      VkCommandPool commandPool;
 /*** END OF REFACTORED CODE ***/
-
-      VkCommandPool commandPool;
       vector<VkCommandBuffer> commandBuffers;
 
@@ -322 +322 @@
          createImageViews();
          createRenderPass();
+
+         createCommandPool();
 /*** END OF REFACTORED CODE ***/
-
-         createCommandPool();
 
          createImageResources("textures/texture.jpg", textureImage, textureImageMemory, textureImageView);
@@ -1025 +1025 @@
       }
 
+/*** START OF REFACTORED CODE ***/
       void createCommandPool() {
          QueueFamilyIndices queueFamilyIndices = findQueueFamilies(physicalDevice);
@@ -1038 +1039 @@
       }
 
-/*** START OF REFACTORED CODE ***/
       QueueFamilyIndices findQueueFamilies(VkPhysicalDevice device) {
          QueueFamilyIndices indices;
@@ -1893 +1893 @@
          }
 
+/*** START OF REFACTORED CODE ***/
          vkDestroyCommandPool(device, commandPool, nullptr);
-/*** START OF REFACTORED CODE ***/
          vkDestroyDevice(device, nullptr);
          vkDestroySurfaceKHR(instance, surface, nullptr);