Changeset 31b347a in network-game for client/Client/main.cpp

Timestamp:

Dec 17, 2013, 2:11:14 PM (11 years ago)

Author:

Dmitry Portnoy <dportnoy@…>

Branches:

master

Children:

453087e

Parents:

e103b51

Message:

When the client receives a PLAYER message, a new PLAYER object is only created if the player doesn't already exist in the player list.

File:

• client/Client/main.cpp (modified) (2 diffs)

client/Client/main.cpp

@@ -743 +743 @@
                cout << "Received MSG_TYPE_PLAYER" << endl;
 
-               Player* p = new Player("", "");
-               p->deserialize(msg.buffer);
-               p->timeLastUpdated = getCurrentMillis();
-               p->isChasing = false;
-               if (p->health <= 0)
-                  p->isDead = true;
+               Player p("", "");
+               p.deserialize(msg.buffer);
+               p.timeLastUpdated = getCurrentMillis();
+               p.isChasing = false;
+               if (p.health <= 0)
+                  p.isDead = true;
                else
-                  p->isDead = false;
-
-               if (mapPlayers.find(p->id) != mapPlayers.end())
-                    delete mapPlayers[p->id];
-               mapPlayers[p->id] = p;
+                  p.isDead = false;
+
+               if (mapPlayers.find(p.id) != mapPlayers.end())
+                  *(mapPlayers[p.id]) = p;
+               else
+                  mapPlayers[p.id] = new Player(p);
 
                break;
@@ -947 +948 @@
                cout << "Received MSG_TYPE_PLAYER" << endl;
 
-               Player* p = new Player("", "");
-               p->deserialize(msg.buffer);
-               p->timeLastUpdated = getCurrentMillis();
-               p->isChasing = false;
-               if (p->health <= 0)
-                  p->isDead = true;
+               Player p("", "");
+               p.deserialize(msg.buffer);
+               p.timeLastUpdated = getCurrentMillis();
+               p.isChasing = false;
+               if (p.health <= 0)
+                  p.isDead = true;
                else
-                  p->isDead = false;
-
-               if (mapPlayers.find(p->id) != mapPlayers.end())
-                    delete mapPlayers[p->id];
-               mapPlayers[p->id] = p;
-
-               game->addPlayer(p);
+                  p.isDead = false;
+
+               if (mapPlayers.find(p.id) != mapPlayers.end())
+                  *(mapPlayers[p.id]) = p;
+               else
+                  mapPlayers[p.id] = new Player(p);
+
+               break;
+
+               // there's a problem here because PLAYER messages will be sent
+               // for players in this game as well as for new players logging in
+               // we might need two different message types
+               game->addPlayer(mapPlayers[p.id]);
 
                break;