Changeset cd487fb in opengl-game

Timestamp:

Nov 12, 2019, 9:48:50 PM (5 years ago)

Author:

Dmitry Portnoy <dmitry.portnoy@…>

Branches:

feature/imgui-sdl, master, points-test

Children:

b8777b7

Parents:

e3bef3a

git-author:

Dmitry Portnoy <dmitry.portnoy@…> (11/12/19 21:25:58)

git-committer:

Dmitry Portnoy <dmitry.portnoy@…> (11/12/19 21:48:50)

Message:

Replace some couts with runtime_exceptions and, in vulkangame, only call SDL_SetRenderTarget once, during initialization

Files:

• TODO.txt (modified) (1 diff)
• graphics-pipeline_vulkan.cpp (modified) (2 diffs)
• graphics-pipeline_vulkan.hpp (modified) (3 diffs)
• vulkan-game.cpp (modified) (2 diffs)
• vulkan-ref.cpp (modified) (1 diff)

TODO.txt

@@ -18 +18 @@
    -Maybe separate out the camera controls
 -Turn the game into more of an overhead view RTS where you can use the mouse to select and move ships
-
-Apparently a new pipeline is required for every type of shader
-However, it seems like I should only need one swap chain 
-Seems like I'll have to create a new set of framebuffers and a new set of command buffers as well
-
-I will definitely have to create new command buffers, since that's where I specify the vertex buffers and
-index buffer for the draw operation
-
-We'll need to have a separate command buffer for every framebuffer in the swapchain
-
-Actually, I could probably just have multiple vkCmdDraw calls in each command buffer and rebind to a different
-pipeline between each one

graphics-pipeline_vulkan.cpp

@@ -3 +3 @@
 #include <fstream>
 #include <stdexcept>
-#include <iostream>
 
 using namespace std;
-
-// TODO: Remove any instances of cout and instead throw exceptions
 
 GraphicsPipeline_Vulkan::GraphicsPipeline_Vulkan(VkPhysicalDevice physicalDevice, VkDevice device,
@@ -315 +312 @@
                break;
             default:
-               cout << "Unknown descriptor type: " << descriptorWrites[j].descriptorType << endl;
+               throw runtime_error("Unknown descriptor type: " + to_string(descriptorWrites[j].descriptorType));
          }
       }

graphics-pipeline_vulkan.hpp

@@ -4 +4 @@
 #include "graphics-pipeline.hpp"
 
-#include <iostream>
+#include <stdexcept>
 #include <vector>
 
@@ -12 +12 @@
 
 using namespace std;
-
-// TODO: Remove any instances of cout and instead throw exceptions
 
 // TODO: Maybe change the name of this struct so I can call the list something other than descriptorInfoList
@@ -113 +111 @@
 bool GraphicsPipeline_Vulkan::addObject(const vector<VertexType>& vertices, vector<uint16_t>& indices,
       VkCommandPool commandPool, VkQueue graphicsQueue) {
-   cout << "Adding object to pipeline..." << endl;
 
    if (numVertices + vertices.size() > vertexCapacity) {
-      cout << "ERROR: Need to resize vertex buffers" << endl;
+      throw runtime_error("ERROR: Need to resize vertex buffers");
    } else if (numIndices + indices.size() > indexCapacity) {
-      cout << "ERROR: Need to resize index buffers" << endl;
+      throw runtime_error("ERROR: Need to resize index buffers");
    } else {
-      cout << "Added object to scene" << endl;
-
       for (uint16_t& idx : indices) {
          idx += numVertices;

vulkan-game.cpp

@@ -165 +165 @@
       return RTWO_ERROR;
    }
+
+   SDL_SetRenderTarget(renderer, uiOverlay);
 
    return RTWO_SUCCESS;
@@ -333 +335 @@
 
 void VulkanGame::renderUI() {
-   // TODO: Since I currently don't use any other render targets,
-   // I may as well set this once before the render loop
-   SDL_SetRenderTarget(renderer, uiOverlay);
-
    SDL_SetRenderDrawColor(renderer, 0x00, 0x00, 0x00, 0x00);
    SDL_RenderClear(renderer);

vulkan-ref.cpp

@@ -1716 +1716 @@
 
       void mainLoop() {
-         // TODO: Create some generic event-handling functions in game-gui-*
+         // TODO: Create some generic event-handling functions in game-gui
          SDL_Event e;
          bool quit = false;