Changeset fe5c3ba in opengl-game

Timestamp:

Sep 22, 2019, 2:28:22 AM (5 years ago)

Author:

Dmitry Portnoy <dmp1488@…>

Branches:

feature/imgui-sdl, master, points-test

Children:

a0c5f28

Parents:

90a424f

Message:

In vulkangame, change the pickPhysicalDevice() and isDeviceSuitable() functions to take the deviceExtensions list as a parameter

Files:

• vulkan-game.cpp (modified) (4 diffs)
• vulkan-game.hpp (modified) (2 diffs)
• vulkan-utils.cpp (modified) (5 diffs)
• vulkan-utils.hpp (modified) (1 diff)

vulkan-game.cpp

@@ -90 +90 @@
       "VK_LAYER_KHRONOS_validation"
    };
+   const vector<const char*> deviceExtensions = {
+      VK_KHR_SWAPCHAIN_EXTENSION_NAME
+   };
 
    createVulkanInstance(validationLayers);
    setupDebugMessenger();
    createVulkanSurface();
-   pickPhysicalDevice();
+   pickPhysicalDevice(deviceExtensions);
 }
 
@@ -239 +242 @@
 }
 
-void VulkanGame::pickPhysicalDevice() {
+void VulkanGame::pickPhysicalDevice(const vector<const char*>& deviceExtensions) {
    uint32_t deviceCount = 0;
    vkEnumeratePhysicalDevices(instance, &deviceCount, nullptr);
@@ -252 +255 @@
    cout << endl << "Graphics cards:" << endl;
    for (const VkPhysicalDevice& device : devices) {
-      if (isDeviceSuitable(device)) {
+      if (isDeviceSuitable(device, deviceExtensions)) {
          physicalDevice = device;
          break;
@@ -264 +267 @@
 }
 
-bool VulkanGame::isDeviceSuitable(VkPhysicalDevice device) {
-   const vector<const char*> deviceExtensions = {
-      VK_KHR_SWAPCHAIN_EXTENSION_NAME
-   };
-
+bool VulkanGame::isDeviceSuitable(VkPhysicalDevice device, const vector<const char*>& deviceExtensions) {
    VkPhysicalDeviceProperties deviceProperties;
    vkGetPhysicalDeviceProperties(device, &deviceProperties);

vulkan-game.hpp

@@ -26 +26 @@
       VkInstance instance;
       VkDebugUtilsMessengerEXT debugMessenger;
-      VkSurfaceKHR surface;
+      VkSurfaceKHR surface; // TODO: Change the variable name to vulkanSurface
       VkPhysicalDevice physicalDevice = VK_NULL_HANDLE;
 
@@ -38 +38 @@
       void populateDebugMessengerCreateInfo(VkDebugUtilsMessengerCreateInfoEXT& createInfo);
       void createVulkanSurface();
-      void pickPhysicalDevice();
-      bool isDeviceSuitable(VkPhysicalDevice device);
+      void pickPhysicalDevice(const vector<const char*>& deviceExtensions);
+      bool isDeviceSuitable(VkPhysicalDevice device, const vector<const char*>& deviceExtensions);
 
       static VKAPI_ATTR VkBool32 VKAPI_CALL debugCallback(

vulkan-utils.cpp

@@ -1 +1 @@
 #include "vulkan-utils.hpp"
 
+#include <algorithm>
 #include <set>
+#include <stdexcept>
 #include <string>
 
@@ -52 +54 @@
 }
 
-QueueFamilyIndices VulkanUtils::findQueueFamilies(VkPhysicalDevice device, VkSurfaceKHR surface) {
+QueueFamilyIndices VulkanUtils::findQueueFamilies(VkPhysicalDevice physicalDevice, VkSurfaceKHR surface) {
    QueueFamilyIndices indices;
 
    uint32_t queueFamilyCount = 0;
-   vkGetPhysicalDeviceQueueFamilyProperties(device, &queueFamilyCount, nullptr);
+   vkGetPhysicalDeviceQueueFamilyProperties(physicalDevice, &queueFamilyCount, nullptr);
 
    vector<VkQueueFamilyProperties> queueFamilies(queueFamilyCount);
-   vkGetPhysicalDeviceQueueFamilyProperties(device, &queueFamilyCount, queueFamilies.data());
+   vkGetPhysicalDeviceQueueFamilyProperties(physicalDevice, &queueFamilyCount, queueFamilies.data());
 
    int i = 0;
@@ -68 +70 @@
 
       VkBool32 presentSupport = false;
-      vkGetPhysicalDeviceSurfaceSupportKHR(device, i, surface, &presentSupport);
+      vkGetPhysicalDeviceSurfaceSupportKHR(physicalDevice, i, surface, &presentSupport);
 
       if (queueFamily.queueCount > 0 && presentSupport) {
@@ -84 +86 @@
 }
 
-bool VulkanUtils::checkDeviceExtensionSupport(VkPhysicalDevice device, const vector<const char*>& deviceExtensions) {
+bool VulkanUtils::checkDeviceExtensionSupport(VkPhysicalDevice physicalDevice, const vector<const char*>& deviceExtensions) {
    uint32_t extensionCount;
-   vkEnumerateDeviceExtensionProperties(device, nullptr, &extensionCount, nullptr);
+   vkEnumerateDeviceExtensionProperties(physicalDevice, nullptr, &extensionCount, nullptr);
 
    vector<VkExtensionProperties> availableExtensions(extensionCount);
-   vkEnumerateDeviceExtensionProperties(device, nullptr, &extensionCount, availableExtensions.data());
+   vkEnumerateDeviceExtensionProperties(physicalDevice, nullptr, &extensionCount, availableExtensions.data());
 
    set<string> requiredExtensions(deviceExtensions.begin(), deviceExtensions.end());
@@ -100 +102 @@
 }
 
-SwapChainSupportDetails VulkanUtils::querySwapChainSupport(VkPhysicalDevice device, VkSurfaceKHR surface) {
+SwapChainSupportDetails VulkanUtils::querySwapChainSupport(VkPhysicalDevice physicalDevice, VkSurfaceKHR surface) {
    SwapChainSupportDetails details;
 
-   vkGetPhysicalDeviceSurfaceCapabilitiesKHR(device, surface, &details.capabilities);
+   vkGetPhysicalDeviceSurfaceCapabilitiesKHR(physicalDevice, surface, &details.capabilities);
 
    uint32_t formatCount;
-   vkGetPhysicalDeviceSurfaceFormatsKHR(device, surface, &formatCount, nullptr);
+   vkGetPhysicalDeviceSurfaceFormatsKHR(physicalDevice, surface, &formatCount, nullptr);
 
    if (formatCount != 0) {
       details.formats.resize(formatCount);
-      vkGetPhysicalDeviceSurfaceFormatsKHR(device, surface, &formatCount, details.formats.data());
+      vkGetPhysicalDeviceSurfaceFormatsKHR(physicalDevice, surface, &formatCount, details.formats.data());
    }
 
    uint32_t presentModeCount;
-   vkGetPhysicalDeviceSurfacePresentModesKHR(device, surface, &presentModeCount, nullptr);
+   vkGetPhysicalDeviceSurfacePresentModesKHR(physicalDevice, surface, &presentModeCount, nullptr);
 
    if (presentModeCount != 0) {
       details.presentModes.resize(presentModeCount);
-      vkGetPhysicalDeviceSurfacePresentModesKHR(device, surface, &presentModeCount, details.presentModes.data());
+      vkGetPhysicalDeviceSurfacePresentModesKHR(physicalDevice, surface, &presentModeCount, details.presentModes.data());
    }
 

vulkan-utils.hpp

@@ -37 +37 @@
             const VkAllocationCallbacks* pAllocator);
 
-      static QueueFamilyIndices findQueueFamilies(VkPhysicalDevice device, VkSurfaceKHR surface);
-      static bool checkDeviceExtensionSupport(VkPhysicalDevice device, const vector<const char*>& deviceExtensions);
-      static SwapChainSupportDetails querySwapChainSupport(VkPhysicalDevice device, VkSurfaceKHR surface);
+      static QueueFamilyIndices findQueueFamilies(VkPhysicalDevice physicalDevice, VkSurfaceKHR surface);
+      static bool checkDeviceExtensionSupport(VkPhysicalDevice physicalDevice, const vector<const char*>& deviceExtensions);
+      static SwapChainSupportDetails querySwapChainSupport(VkPhysicalDevice physicalDevice, VkSurfaceKHR surface);
 };